Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logic refactor & URL Schemes / 3D Touch #141

Open
wants to merge 35 commits into
base: master
Choose a base branch
from

Conversation

nullpixel
Copy link
Contributor

@nullpixel nullpixel commented Jan 28, 2017

  • Made already jailbroken checking a function
  • Removed didReceiveMemoryWarning
  • Added
else if (strstr(u.version, "MarijuanARM")) {
        printf("Already jailbroken\n");
    }

in offsets.c to correctly log the jailbroken state.

  • Added a URL scheme to jailbreak: yalu://break
  • Added a 3D touch action to jailbreak
  • Added a jailbreaking button state
  • Hugely refactored logic
  • App now supports the simulator for testing

Bigger view controller refactor coming soon.

@nullpixel nullpixel changed the title Minor view controller refactor VC refactor & URL Schemes Jan 28, 2017
@nullpixel nullpixel changed the title VC refactor & URL Schemes URL Schemes & 3D Touch! Jan 28, 2017
Copy link

@meyer9 meyer9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@@ -2,6 +2,26 @@
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>UIApplicationShortcutItems </key>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra space in key name likely stops this from appearing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks b

@AppleBetas
Copy link

The app can now be built for and run in the simulator. Upon pressing "go", the user is greeted with the following screen:

Simulator jailbreak alert

@nullpixel
Copy link
Contributor Author

^ We're currently using it to manipulate bools, and test 3D touch

@nullpixel nullpixel changed the title URL Schemes & 3D Touch! Logic refactor & URL Schemes / 3D Touch Jan 28, 2017
@nullpixel
Copy link
Contributor Author

Okay, this should be good to merge now!

@nullpixel
Copy link
Contributor Author

@Mila432 What part of the code are you referring to?

@Mila432
Copy link
Contributor

Mila432 commented Jan 29, 2017

@nullpixel1 d02d694 no idea why GitHub moved the comment here

@nullpixel
Copy link
Contributor Author

nullpixel commented Jan 29, 2017

@Mila432 ohhhh

Look at the file it's in: it's my own jailbreak check, not the offsets.

To shed more light on it, ==0 was a debug statement I added to always make that return true for testing, but I forgot to remove it from the vc before committing.

@Mila432
Copy link
Contributor

Mila432 commented Jan 29, 2017

@nullpixel1 ye old code was c= a == b , new code c = a

@nullpixel
Copy link
Contributor Author

yeah, it was a debug statement @Mila432

@nullpixel
Copy link
Contributor Author

nullpixel commented Jan 29, 2017

@kpwn this PR now updates readme for new jailbreak, and should clarify some support questions.

@kpwn
Copy link
Owner

kpwn commented Jan 29, 2017

I am not OK with a URI scheme to initiate a jailbreak. Sounds sketch.

@nullpixel
Copy link
Contributor Author

nullpixel commented Jan 29, 2017

@kpwn The user has to press ok to do it when launched via a URL scheme. It's mainly there for things such as workflow.

@nullpixel
Copy link
Contributor Author

@kpwn Sorry, forgot to commit the alert view, can you re-review this now?

@nullpixel
Copy link
Contributor Author

Rebased

@AppleBetas
Copy link

Resolved conflicts

@nullpixel
Copy link
Contributor Author

Resolved merge conflict

Bring up to date with master
@nullpixel
Copy link
Contributor Author

@kpwn

Did you change your mind about URL schemes or should I factor them out?

Bring up to date with base
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants