-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow for tracking coverage #17
Conversation
3f9b4ca
to
c951fbe
Compare
Coverage Report Results
|
3ede9cf
to
be12c87
Compare
This is not only unecessary but it is also a copy-paste issue as this repo is definitely not called django_integrity.
bf7708a
to
9875ff2
Compare
This package was added via `make dev`.
- name: Comment PR with coverage report | ||
uses: thollander/actions-comment-pull-request@v2 | ||
with: | ||
filePath: /tmp/coverage_report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sadly I can't use $REPORT_PATH here as above. The actions-comment-pull-request
Workflow doesn't seem to support env variables here.
9875ff2
to
f482013
Compare
uses: thollander/actions-comment-pull-request@v2 | ||
with: | ||
filePath: /tmp/coverage_report | ||
comment_tag: pr_comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so that instead of creating new comments for each push, it just creates one and updates it if a new push has happened.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine.
For papertrail, I asked outside of the PR why this couldn't be added on top of the existing tests and answer is speed. So the choice is to run code coverage on only one combination that the tests run under.
GitHub Workflow For Printing Coverage Result
This PR adds a new GitHub Workflow that uses the
coverage
package (from Pypi) to run reports on the testing coverage.This code could be swapped for, or enhanced by, a codecov subscription in future.