Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: delete logic #37

Merged
merged 1 commit into from
Jul 30, 2024
Merged

fix: delete logic #37

merged 1 commit into from
Jul 30, 2024

Conversation

matteogastaldello
Copy link
Contributor

  • Delete fails when an error is retrieved in the steps during install, deleting the CR without uninstalling releases

Solved

  • Delete is wrong implemented, the steps list should be evaluated with a bottom up logic

Solved

@matteogastaldello matteogastaldello self-assigned this Jul 30, 2024
@matteogastaldello matteogastaldello linked an issue Jul 30, 2024 that may be closed by this pull request
Deletion Errors #36
Closed
@braghettos braghettos merged commit 4ceb78e into main Jul 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braghettos braghettos Awaiting requested review from braghettos

Assignees

@matteogastaldello matteogastaldello

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deletion Errors
2 participants
@matteogastaldello @braghettos