fix: Incorrect event name logging when subscribing with :with option #217
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #215:
Issue Description
when using
![image](https://private-user-images.githubusercontent.com/50241297/369887378-2635d508-f53b-4f07-8686-d3c21c1d602d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwNTAxMDUsIm5iZiI6MTczOTA0OTgwNSwicGF0aCI6Ii81MDI0MTI5Ny8zNjk4ODczNzgtMjYzNWQ1MDgtZjUzYi00ZjA3LTg2ODYtZDNjMjFjMWQ2MDJkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA4VDIxMjMyNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTc0Mzc4MDdlM2JlZDYwOWU0NGFlNmY1NzlkNzU2ZjhhMzE0NDlmYjFlYjZmMDI3ODM4YTVlMjc0ZmRhOTYxYTYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.ulU5WKugzhvkVUcbcyNVurH7X1L9lTrZQUBuoiWFA0U)
LoggerBroadcaster
, the message flow is as follows::The
method_to_call
argument passed from ObjectRegistration to Broadcasters::LoggerBroadcaster is incorrectly interpreted as the event name in the logging, resulting in incorrect logged information.Solution
This PR ensures that
ObjectRegistration
/LoggerBroadcaster
correctly handles theevent
andmethod_to_call
argumentNote: Although
Broadcasters::SendBroadcaster#broadcast
does not require theevent
argument and only needs themethod_to_call
argument, all broadcasters are designed to have a consistent#broadcast
method interface. Therefore, they should share the same argument structure.