Multi-database support #4 #6
Conversation
|
Ok, this is actually broken, as it tries to go to multiple places in 1 page at the same time. Let me fix that |
|
this is so awesome!! i didn't know that multi-database support was a thing in roam, but i've seen a bunch of people asking about this so i'm thrilled you took the time to get this PR up! anything i can do to help it along the finish line? i see a few TODOs in the diff. let me know! also thanks for the re-indent fix, not sure what happened there! |
|
This is functional, I think it can be merged as is. TODO's are more of a wish-list for improvements |
|
There is a bug when switch to JSON export type does not work for large db's, but I don't believe it's related to changes here |
|
Do you have any concerns you want addressed before merging this? |
|
👀 |
|
hey @Stvad, sorry for the lack of review on this! i've been pretty bad about my github notifications :| reviewing now |
|
I had some issues running this: https://github.com/signalnerve/roam-backup/runs/622833348?check_suite_focus=true @Stvad any ideas? |
| @@ -4,18 +4,17 @@ on: | |||
| push: | |||
| branches: | |||
| - master | |||
| schedule: | |||
There was a problem hiding this comment.
ah, this PR got stale - the intended changes were only the ones before March 19. But I continued to work on my branch so they show up here.
There was a problem hiding this comment.
to answer your actual question - I actually switched to using https://github.com/MatthieuBizien/roam-to-git so I disabled the WF for myself.
| const generateExport = async () => { | ||
| const browser = await puppeteer.launch({ | ||
| env: { | ||
| TZ: 'Etc/GMT+12', |
No description provided.