Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the NPE issue in ListExperimentsAPI #1030

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Fix the NPE issue in ListExperimentsAPI #1030

merged 3 commits into from
Jan 30, 2024

Conversation

khansaad
Copy link
Contributor

@khansaad khansaad commented Nov 7, 2023

This PR fixes #908

  • Removed the redundant convert method
  • Removed the unused post method

@khansaad khansaad added the bug Something isn't working label Nov 7, 2023
@khansaad khansaad added this to the Kruize 0.0.20.1_rm Release milestone Nov 7, 2023
@khansaad khansaad self-assigned this Nov 7, 2023
@khansaad khansaad linked an issue Nov 7, 2023 that may be closed by this pull request
ListExperiments API throws java.lang.NullPointerException: Cannot invoke "java.util.HashMap.values()" #908
Closed
@khansaad khansaad force-pushed the fix-list-exp-errors branch from 836b8e0 to fe99cb7 Compare December 15, 2023 12:52
@khansaad khansaad marked this pull request as ready for review December 15, 2023 12:58
@khansaad khansaad changed the title [WIP] Fix the NPE issue in ListExperimentsAPI Fix the NPE issue in ListExperimentsAPI Dec 15, 2023
chandrams
chandrams reviewed Dec 18, 2023
View reviewed changes
...ripts/remote_monitoring_tests/fault_tolerant_tests/remote_monitoring_fault_tolerant_tests.sh Outdated
@@ -174,7 +174,7 @@ if [ "${exit_code}" -ne 0 ]; then
echo "Fault tolerant test failed! Check the log for details" | tee -a ${LOG}
exit 1
else
if [[ $(grep -i "error\|exception" ${KRUIZE_POD_LOG_BEFORE}) || $(grep -i "error\|exception" ${KRUIZE_POD_LOG_AFTER}) ]]; then
if [[ $(grep -i "ERROR" ${KRUIZE_POD_LOG_BEFORE}) || $(grep -i "error\|exception" ${KRUIZE_POD_LOG_AFTER}) ]]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khansaad - Why has this been changed?

@chandrams
Copy link
Contributor

With fault tolerant test I see such messages as shown below in the pod log, these were not seen earlier, can you check.

[36.236s][warning][os,thread] Failed to start thread "Unknown thread" - pthread_create failed (EAGAIN) for attributes: stacksize: 1024k, guardsize: 0k, detached.
[36.236s][warning][os,thread] Failed to start thread "Unknown thread" - pthread_create failed (EAGAIN) for attributes: stacksize: 1024k, guardsize: 0k, detached.
[36.237s][warning][os,thread] Failed to start thread "Unknown thread" - pthread_create failed (EAGAIN) for attributes: stacksize: 1024k, guardsize: 0k, detached.
[36.238s][warning][os,thread] Failed to start thread "Unknown thread" - pthread_create failed (EAGAIN) for attributes: stacksize: 1024k, guardsize: 0k, detached.
2023-12-1807:18:36.938 WARN [qtp253011924-45][ExperimentDBService.java(99)]-Converted experimentResultData is null
2023-12-1807:18:36.939 WARN [qtp253011924-45][ExperimentDBService.java(99)]-Converted experimentResultData is null
2023-12-1807:18:36.939 WARN [qtp253011924-45][ExperimentDBService.java(99)]-Converted experimentResultData is null
2023-12-1807:18:36.939 WARN [qtp253011924-45][ExperimentDBService.java(99)]-Converted experimentResultData is null
2023-12-1807:18:36.939 WARN [qtp253011924-45][ExperimentDBService.java(99)]-Converted experimentResultData is null

chandrams
chandrams approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@chandrams chandrams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dinogun dinogun merged commit 5575a73 into kruize:mvp_demo Jan 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msvinaykumar msvinaykumar msvinaykumar approved these changes

@chandrams chandrams chandrams approved these changes

Assignees

@khansaad khansaad

Labels
bug Something isn't working
Projects
Monitoring
Status: Done
Milestone
Kruize 0.0.20.2_rm Release
Development

Successfully merging this pull request may close these issues.

ListExperiments API throws java.lang.NullPointerException: Cannot invoke "java.util.HashMap.values()"
5 participants
@khansaad @chandrams @msvinaykumar @dinogun @rbadagandi1