Adding Functionality to Dynamically Calculate Threshold Value For Minimum Time Required For Term #1466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shekhar Saxena <[email protected]>
Signed-off-by: Shekhar Saxena <[email protected]>
Signed-off-by: Shekhar Saxena <[email protected]>
Signed-off-by: Shekhar Saxena <[email protected]>
|
@dinogun I’ve updated the threshold calculation logic as per our discussion. Please review it whenever you have a moment and let me know your suggestions. |
shekhar316
changed the title
dinogun
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Looking good for now. We need to make these configurable from a user perspective, so these need to be added to the config changes as well
cc: @bhanvimenghani
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the threshold calculation logic to dynamically calculate based on user-provided minimum default values for
measurement_duration.Fixes # (issue)
Delay in generating the recommendations during demos
Type of change
How has this been tested?
Manually with OpenShift Cluster
Test Configuration
Checklist 🎯
Additional information
Image for Testing: quay.io/rh-ee-shesaxen/autotune:hello2