Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve helmclient for OCI charts #513

Merged
merged 3 commits into from
Jan 26, 2025
Merged

Improve helmclient for OCI charts #513

merged 3 commits into from
Jan 26, 2025

Conversation

dipankardas011
Copy link
Member

🗒️ Changelog

  • New Helm client with Options
  • improved customization for the helm oci charts

🏋🏼 Issues

✅ Completed Issues

🚀 Task List

  • Mentioned in the Bug report

🔍 Review Checklist

  • Code follows project style guidelines
  • Added/updated tests
  • Ran tests locally
  • Updated documentation
  • Checked Contribution Guidelines

📸 Screenshots/Recordings

📌 Additional Notes

💡 PR best practices
  • Keep changes focused and atomic
  • Update tests and documentation
  • Check for conflicts with main branch
  • Respond promptly to review comments
  • Follow project coding standards
  • Make sure you are using pre-commit for that run this command $ pre-commit install

@dipankardas011 dipankardas011 marked this pull request as ready for review January 26, 2025 18:01
@dipankardas011 dipankardas011 added pr/lgtm This PR look good to the reviewer tests/enable it enables the PR to start tests labels Jan 26, 2025
@dipankardas011 dipankardas011 changed the title Improve helmclient Improve helmclient for OCI charts Jan 26, 2025
@dipankardas011 dipankardas011 mentioned this pull request Jan 26, 2025
Merged
5 tasks
@dipankardas011 dipankardas011 merged commit 1e1931d into main Jan 26, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Horiodino Horiodino Awaiting requested review from Horiodino Horiodino is a code owner

Assignees
No one assigned
Labels
pr/lgtm This PR look good to the reviewer tests/enable it enables the PR to start tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Helm OCI based charts not able to install
1 participant
@dipankardas011