Add visionOS support #452
Merged
Add visionOS support #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GLinnik21
reviewed
Nov 12, 2023
GLinnik21
reviewed
Nov 12, 2023
| @@ -38,7 +38,8 @@ | |||
| #define KSCRASH_HOST_IOS (KSCRASH_HOST_APPLE && TARGET_OS_IOS) | |||
| #define KSCRASH_HOST_TV (KSCRASH_HOST_APPLE && TARGET_OS_TV) | |||
| #define KSCRASH_HOST_WATCH (KSCRASH_HOST_APPLE && TARGET_OS_WATCH) | |||
| #define KSCRASH_HOST_MAC (KSCRASH_HOST_APPLE && TARGET_OS_MAC && !(TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_WATCH)) | |||
| #define KSCRASH_HOST_VISION (KSCRASH_HOST_APPLE && TARGET_OS_VISION) | |||
| #define KSCRASH_HOST_MAC (KSCRASH_HOST_APPLE && TARGET_OS_MAC && !(TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_WATCH || TARGET_OS_VISION)) | |||
There was a problem hiding this comment.
What about TARGET_OS_MACCATALYST?
There was a problem hiding this comment.
Good question, but not related to this PR. Feel free to investigate
GLinnik21
reviewed
Nov 13, 2023
bamx23
commented
Mar 16, 2024
| const NXArchInfo* archInfo = NXGetLocalArchInfo(); | ||
| return archInfo == NULL ? NULL : archInfo->name; | ||
| #if !KSCRASH_HOST_VISION | ||
| if(__builtin_available(iOS 16.0, macOS 13.0, tvOS 16.0, watchOS 8.0, *)) |
There was a problem hiding this comment.
visionOS seems to not being supported in @available and __builtin_available. So for it I just use new API without any checks.
bamx23
force-pushed
the
visionos
branch
8 times, most recently
from
28f11a4
to
0d3128c
Compare
Open
GLinnik21
approved these changes
May 7, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick itteration on visionOS support.
I've briefly checked that some of the crash types and looks like it works just fine.
So far CocoaPods doesn't fully support visionOS (e.g. CocoaPods/CocoaPods#12118), so keeping this as a PR.