Implement the new installation and configuration mechanism #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
GLinnik21
commented
Jun 13, 2024
| * | ||
| * **Default**: NULL | ||
| */ | ||
| @property (nonatomic, copy, nullable) void (^crashNotifyCallback)(const struct KSCrashReportWriter* writer); |
There was a problem hiding this comment.
This is the "ugly" API for Swift. KSCrashReportWriter is a struct that deeply integrated in KSCrash and used in callback, that makes it hard to proxy.
Visible to Swift:
open var crashNotifyCallback: ((UnsafePointer<KSCrashReportWriter>) -> Void)?
There was a problem hiding this comment.
Wrapping this in an ObjC class would be a really good thing to have. Swift API matters.
There was a problem hiding this comment.
From docs
* WARNING: Only call async-safe functions from this function! DO NOT call
* Objective-C methods!!!
There was a problem hiding this comment.
Right. Well, it's fine then.
I'm thinking that a wrapper with all methods being __attribute__((objc_direct)) might do the trick, but it's still ObjC.
bamx23
reviewed
Jun 15, 2024
| * | ||
| * **Default**: NULL | ||
| */ | ||
| @property (nonatomic, copy, nullable) void (^crashNotifyCallback)(const struct KSCrashReportWriter* writer); |
There was a problem hiding this comment.
Wrapping this in an ObjC class would be a really good thing to have. Swift API matters.
bamx23
requested changes
Jun 17, 2024
bamx23
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @naftaly in #491 (comment)