Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix user reported exceptions #589

Merged
merged 1 commit into from
Nov 2, 2024

Conversation

Sergey70
Copy link
Contributor

@Sergey70 Sergey70 commented Nov 2, 2024

There is an issue where manually reported user exceptions were incorrectly processed as application crashes. Previously, user-reported exceptions would be handled by the crash handling flow, which could lead to confusion in reporting and misrepresentation of error types in our monitoring system.

@bamx23
Copy link
Collaborator

bamx23 commented Nov 2, 2024

Thanks for fixing this!
I'm merging this PR and will ensure test coverage in the #588 where I'm adding new integration tests.
Once both fixes are landed I'll make a relase.

@bamx23 bamx23 merged commit 789258a into kstenerud:master Nov 2, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants