Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scp_functions.py | Added support to display progress bar without cleaning the screen. #3247

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

andrearaujo1988
Copy link

Added support to display progress bar without cleaning the screen.
Now it should only shows the percentange and not the progress bar char ">".
Also removed unused vars on the progress_bar function due to this update.
I thought this would be useful since clearing the screen makes the screen to scroll which is not often desired.

Added support to display progress bar without cleaning the screen.
Now it should only shows the percentange and not the progress bar char ">".
…ut cleaning the screen

Added support to display progress bar without cleaning the screen.
Now it should only shows the percentange and not the progress bar char ">".
Also removed unused vars on the progress_bar function due to this update.
@ktbyers
Copy link
Owner

ktbyers commented Jul 7, 2023

This was more an example progress bar that works reasonably well (i.e. if you don't like the provided one, you can just create your own).

I am not sure I understood this?

I thought this would be useful since clearing the screen makes the screen to scroll which is not often desired.

Can you expand/clarify the behavior that you observe?

@andrearaujo1988
Copy link
Author

This was more an example progress bar that works reasonably well (i.e. if you don't like the provided one, you can just create your own).

I am not sure I understood this?

I thought this would be useful since clearing the screen makes the screen to scroll which is not often desired.

Can you expand/clarify the behavior that you observe?

When passing the progress bar imported from scp_functions I've noticed that the screen keeps getting cleared and new status being printed which makes the screen to scroll until the file transfer is done.
If you need to scroll up to find something you'll have hard times since the screen got populated with every updated on the progress.
I thought it would be 'better' if the progress gets written on the screen but withing the same like and only the percentage being refreshed.
If I can pass my progress it would be great, but I'm not sure how to do so and pass the arguments I want if you can refer me to any documentation with example it would be great.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants