Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix Mikrotik version > 6.48 = 'export' command incomplete #3405 #3467

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

Tonygratta
Copy link
Contributor

This fix generates a regex string for search pattern using in send_command function for MikroTik devices. This regex expression searches not just the prompt string, but the prompt string exactly at the end of the output string, without any symbols after it. It prevents premature termination of the collecting data process.

Checked on hardware:

  • RouterBOARD 941-2nD FW v6.42.1, 6.49.7, 6.49.15
  • RouterBOARD 951-2n FW v6.49.7

Tonygratta and others added 4 commits July 26, 2024 19:38
Prompt regex for MikroTik generates so it matches only if prompt string is found in the end of string (no more printable symbols were printed after it).
@ktbyers
Copy link
Owner

ktbyers commented Aug 2, 2024

Does just switching to dumb terminal setting make this change unnecessary?

See:
#3405

@Tonygratta
Copy link
Contributor Author

Tried that, but unfortunately it doesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants