-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KTOR-6632 Support receiving multipart data with Ktor client #4458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e5l
force-pushed
the
e5l/client-multipart
branch
2 times, most recently
from
November 6, 2024 14:18
0a1d9f5
to
160615a
Compare
whyoleg
reviewed
Nov 6, 2024
osipxd
requested changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
Please check the comments below
ktor-http/ktor-http-cio/jsAndWasmShared/src/io/ktor/http/cio/MultipartJsAndWasm.kt
Outdated
Show resolved
Hide resolved
ktor-http/ktor-http-cio/jsAndWasmShared/src/io/ktor/http/cio/MultipartJsAndWasm.kt
Show resolved
Hide resolved
ktor-http/ktor-http-cio/common/src/io/ktor/http/cio/MultipartCommon.kt
Outdated
Show resolved
Hide resolved
ktor-client/ktor-client-core/common/src/io/ktor/client/plugins/DefaultTransform.kt
Outdated
Show resolved
Hide resolved
ktor-client/ktor-client-core/common/src/io/ktor/client/plugins/DefaultTransform.kt
Outdated
Show resolved
Hide resolved
e5l
force-pushed
the
e5l/client-multipart
branch
from
November 11, 2024 13:32
fff1387
to
59b5b83
Compare
osipxd
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Please, check code style before merging
e5l
added a commit
that referenced
this pull request
Nov 13, 2024
* KTOR-6632 Support receiving multipart data with Ktor client
e5l
added a commit
that referenced
this pull request
Nov 14, 2024
* KTOR-6632 Support receiving multipart data with Ktor client
osipxd
pushed a commit
that referenced
this pull request
Nov 16, 2024
* KTOR-6632 Support receiving multipart data with Ktor client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix KTOR-6632 Support receiving multipart data with Ktor client