KTOR-7729 Add logging for tracking concurrent access in the dev mode #4477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjhham
approved these changes
Nov 13, 2024
| init { | ||
| if (DEVELOPMENT_MODE) { | ||
| created = Throwable("ReadTask 0x${continuation.hashCode().toString(16)}").also { | ||
| it.stackTraceToString() |
There was a problem hiding this comment.
Is this also { it.stackTraceToString() } doing anything here?
There was a problem hiding this comment.
yep, by default the stacktrace is not filled
|
|
||
| init { | ||
| if (DEVELOPMENT_MODE) { | ||
| created = Throwable("ReadTask 0x${continuation.hashCode().toString(16)}").also { |
There was a problem hiding this comment.
It'd be nice if we appended some diagnostic info from the coroutine context here too, since sometimes the stacktraces can be hard to follow as well.
There was a problem hiding this comment.
we don't have it in the init block, let me check what we can do
osipxd
reviewed
Nov 14, 2024
Comment on lines
+272
to
+275
| public class ConcurrentIOException( | ||
| taskName: String, | ||
| cause: Throwable? = null | ||
| ) : IllegalStateException("Concurrent $taskName attempts", cause) { |
There was a problem hiding this comment.
Should we provide a @Deprecated(HIDDEN) constructor with an old signature for binary compatibility purpose?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will help with the investigation of KTOR-7729 Kotlinx-io
Check failedfromByteChannel