Revert "prevent memory corruption in dbengine" (netdata#19364)

Revert "prevent memory corruption in dbengine (netdata#19363)" This reverts commit 50fb61d.
ktsaou · Jan 10, 2025 · d447f55 · d447f55
1 parent 50fb61d
commit d447f55
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/database/engine/rrdengineapi.c b/src/database/engine/rrdengineapi.c
@@ -911,8 +911,8 @@ void rrdeng_load_metric_finalize(struct storage_engine_query_handle *seqh)
         pgdc_reset(&handle->pgdc, NULL, UINT32_MAX);
     }
 
-    __atomic_store_n(&handle->pdc->workers_should_stop, true, __ATOMIC_RELAXED);
-    pdc_release_and_destroy_if_unreferenced(handle->pdc, false, false);
+    if(!pdc_release_and_destroy_if_unreferenced(handle->pdc, false, false))
+        __atomic_store_n(&handle->pdc->workers_should_stop, true, __ATOMIC_RELAXED);
 
     unregister_query_handle(handle);
     rrdeng_query_handle_release(handle);