Simplify IOPlugin.Data initialization #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the need to specify every component of Data. This introduces a new IOPlugin.PersistedData member which is the same as IOPlugin.Data, except that it is initialized with boolean False instead of None. Also remove account_key and key from FullChainFile, it is not stored by ChainFile. Replace a weird `IOPlugin.EMPTY_DATA._replace(key=X)` hack by the more intuitive `Data(key=X)`. The `__defaults__` construct is taken from http://stackoverflow.com/a/18348004 and documented in https://docs.python.org/2/reference/datamodel.html and https://docs.python.org/3/reference/datamodel.html
Lekensteyn
force-pushed
the
ioplugin-data-simplify
branch
from
f4440f5 to
d7dc719
Compare
| @@ -689,13 +693,11 @@ def load(self): | |||
| cert, chain = None, None | |||
| else: | |||
| cert, chain = data.chain[0], data.chain[1:] | |||
| return self.Data(account_key=data.account_key, key=data.key, | |||
| cert=cert, chain=chain) | |||
| return self.Data(cert=cert, chain=chain) | |||
There was a problem hiding this comment.
Reusing data.account_key or data.key was intentional - it plays well with the inheritance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the need to specify every component of Data. This introduces a
new IOPlugin.PersistedData member which is the same as IOPlugin.Data,
except that it is initialized with boolean False instead of None.
Also remove account_key and key from FullChainFile, it is not stored by
ChainFile. Replace a weird
IOPlugin.EMPTY_DATA._replace(key=X)hack bythe more intuitive
Data(key=X).The
__defaults__construct is taken fromhttp://stackoverflow.com/a/18348004 and documented in
https://docs.python.org/2/reference/datamodel.html and
https://docs.python.org/3/reference/datamodel.html