Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try out offficial prometheus_client for metrics #72

Merged
merged 7 commits into from
Sep 9, 2024
Merged

Conversation

clux
Copy link
Member

@clux clux commented Jun 21, 2024

A working POC for prometheus/client_rust ripping out tikv/rust-prometheus. Not much easier than measured (via #71) because the documentation is lackluster, but the codebase ends up being slightly nicer (and proc macro stuff less confusing for sure).

PROS:

CONS:

This is not updated well enough that I would be comfortable using it. If it had working protobuf and maybe native histograms or something this would be worth talking about, but it's only really bringing some slight ergonomics + exemplars to the table, that's useless if they don't update depedendencies. We don't have to choose this. There's no major downside for using an unofficial metrics crate if offical upstream is just a collection of unoptimized structs putting client in its name to make itself seem important.

@clux clux changed the title Official prom client Try out offficial prom client Jun 21, 2024
@clux clux changed the title Try out offficial prom client Try out offficial prometheus_client Jun 22, 2024
@clux clux linked an issue Jun 22, 2024 that may be closed by this pull request
2 tasks
@clux clux changed the title Try out offficial prometheus_client Try out offficial prometheus_client for metrics Jun 22, 2024
Signed-off-by: clux <[email protected]>
@clux
Copy link
Member Author

clux commented Sep 7, 2024

Exemplar showcase.
grim-area-2024-09-07-11_48_56

Likely to merge this pr over the other for this feature.

@clux clux marked this pull request as ready for review September 9, 2024 09:13
@clux clux merged commit 27586aa into main Sep 9, 2024
7 checks passed
@clux clux deleted the official-prom-client branch September 9, 2024 09:13
@clux clux linked an issue Oct 10, 2024 that may be closed by this pull request
This was referenced Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

try out other prometheus client libraries exemplars support
1 participant