-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try out offficial prometheus_client
for metrics
#72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
clux
force-pushed
the
official-prom-client
branch
from
June 21, 2024 23:32
0d1c45a
to
e67b6d8
Compare
clux
changed the title
Try out offficial prom client
Try out offficial Jun 22, 2024
prometheus_client
2 tasks
clux
changed the title
Try out offficial
Try out offficial Jun 22, 2024
prometheus_client
prometheus_client
for metrics
clux
force-pushed
the
official-prom-client
branch
from
June 23, 2024 23:13
ec83b7d
to
ccc8493
Compare
Signed-off-by: clux <[email protected]>
Signed-off-by: clux <[email protected]>
Signed-off-by: clux <[email protected]>
Signed-off-by: clux <[email protected]>
Signed-off-by: clux <[email protected]>
Signed-off-by: clux <[email protected]>
clux
force-pushed
the
official-prom-client
branch
from
June 24, 2024 07:57
a5d9428
to
6609fcf
Compare
Signed-off-by: clux <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A working POC for prometheus/client_rust ripping out tikv/rust-prometheus. Not much easier than
measured
(via #71) because the documentation is lackluster, but the codebase ends up being slightly nicer (and proc macro stuff less confusing for sure).PROS:
CONS:
measured
's patterns manuallyString
This is not updated well enough that I would be comfortable using it. If it had working protobuf and maybe native histograms or something this would be worth talking about, but it's only really bringing some slight ergonomics + exemplars to the table, that's useless if they don't update depedendencies. We don't have to choose this. There's no major downside for using an unofficial metrics crate if offical upstream is just a collection of unoptimized structs putting
client
in its name to make itself seem important.