Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to hyper 1 #1438

Merged
merged 2 commits into from
Mar 25, 2024
Merged

update to hyper 1 #1438

merged 2 commits into from
Mar 25, 2024

Conversation

tottoto
Copy link
Contributor

@tottoto tottoto commented Mar 23, 2024

Resolves #1351.

@tottoto tottoto force-pushed the update-to-hyper-1 branch 2 times, most recently from 52a8c5d to 85c9ee1 Compare March 23, 2024 06:37
Copy link

codecov bot commented Mar 23, 2024

Codecov Report

Attention: Patch coverage is 58.00000% with 42 lines in your changes are missing coverage. Please review.

Project coverage is 72.1%. Comparing base (bc74325) to head (8118092).

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1438     +/-   ##
=======================================
- Coverage   72.2%   72.1%   -0.1%     
=======================================
  Files         78      78             
  Lines       6546    6594     +48     
=======================================
+ Hits        4722    4749     +27     
- Misses      1824    1845     +21     
Files Coverage Δ
kube-client/src/api/mod.rs 68.8% <ø> (ø)
kube-client/src/client/auth/mod.rs 50.5% <ø> (ø)
kube-client/src/client/middleware/mod.rs 94.0% <100.0%> (ø)
kube-client/src/client/upgrade.rs 81.5% <ø> (ø)
kube-client/src/lib.rs 75.2% <ø> (ø)
kube/src/mock_tests.rs 97.9% <ø> (ø)
kube-client/src/client/builder.rs 59.0% <83.4%> (ø)
kube-client/src/client/auth/oidc.rs 56.9% <25.0%> (-0.3%) ⬇️
kube-client/src/client/auth/oauth.rs 0.0% <0.0%> (ø)
kube-client/src/client/body.rs 87.9% <87.5%> (-12.1%) ⬇️
... and 3 more

Signed-off-by: tottoto <[email protected]>
Signed-off-by: tottoto <[email protected]>
Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh my god! thank you so much for doing this. you are a hero.

i could not for the life of me figure out what to do with Body, but it's relieving to see that with the one you added in body.rs everything mostly falls into place.

@clux clux added the changelog-change changelog change category for prs label Mar 23, 2024
@clux clux requested a review from mateiidavid March 23, 2024 08:19
@clux
Copy link
Member

clux commented Mar 25, 2024

Was stress testing this a bit this morning and not able to break anything that was not already broken. So, in short, I am just going to merge this; it manages to do this monumental upgrade while providing minimal breaking changes:

  1. kube's new Body type needed rather than hyper::Body (gone) for integration tests and custom clients
  2. custom clients have slightly different builder args; legacy client use and an explicit executor

I expect we will need some follow-ups here to move onto less legacy interfaces, but this gets us heading in the right direction, and we will stop blocking downstream apps from upgrading hyper/http.

@clux clux merged commit aeb4d3f into kube-rs:main Mar 25, 2024
18 checks passed
@tottoto tottoto deleted the update-to-hyper-1 branch March 25, 2024 12:48
@clux clux mentioned this pull request Mar 25, 2024
@aviramha
Copy link
Contributor

Adding my thanks to @clux this will be extremely helpful!

@clux clux added this to the 0.89.0 milestone Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-change changelog change category for prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency upgrades for hyper and http 1.0
3 participants