conditionally install aws-lc-rs

[goenning]

Motivation

There was a recent panic on our app ( aptakube/aptakube#319 ) and it was caused by this unwrap

Solution

I suppose we should always check if there's a CryptoProvider already installed before installing another one. That's how it's done here

kube/kube-client/src/client/builder.rs

Lines 85 to 92 in ecbdafc

	#[cfg(all(feature = "aws-lc-rs", feature = "rustls-tls"))]
	{
	if rustls::crypto::CryptoProvider::get_default().is_none() {
	// the only error here is if it's been initialized in between: we can ignore it
	// since our semantic is only to set the default value if it does not exist.
	let _ = rustls::crypto::aws_lc_rs::default_provider().install_default();
	}
	}

but for some reason the oidc.rs did not

I'm also explicitly installing aws_lc_rs (with a fallback to ring) on my app, so I would expect kube to just skip it as it's already installed

cc @mcluseau

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.3%. Comparing base (ecbdafc) to head (ac24670).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##            main   #1617     +/-   ##
=======================================
+ Coverage   75.3%   75.3%   +0.1%     
=======================================
  Files         82      82             
  Lines       7343    7344      +1     
=======================================
+ Hits        5527    5528      +1     
  Misses      1816    1816             

Files with missing lines	Coverage Δ
kube-client/src/client/auth/oidc.rs	56.4% <100.0%> (+0.3%)	⬆️

[mcluseau]

Hi @goenning , I agree. It triggers some "should we factorize this" questions in my mind, but that's a question for another day :)
/lgtm

[clux]

Thanks for this. I see (after initially being wrong and deleting my first comment) that we do this already in one other place, and bubble up an error in oauth.

I guess the oauth one is coming through tame-oauth so it makes sense it's different.