Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom client tls ex #1619

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Fix custom client tls ex #1619

merged 3 commits into from
Oct 25, 2024

Conversation

clux
Copy link
Member

@clux clux commented Oct 25, 2024

#1618 is a legit issue. The example was being skipped due to not being given --all-features.

was not building on CI because it needs --all-features

Signed-off-by: clux <[email protected]>
@clux clux added docs unclear documentation changelog-exclude changelog excluded prs labels Oct 25, 2024
@clux clux added this to the 0.97.0 milestone Oct 25, 2024
@clux clux marked this pull request as ready for review October 25, 2024 18:49
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.3%. Comparing base (4a63e81) to head (2000a29).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1619   +/-   ##
=====================================
  Coverage   75.3%   75.3%           
=====================================
  Files         82      82           
  Lines       7344    7344           
=====================================
  Hits        5528    5528           
  Misses      1816    1816           

@clux clux merged commit 2fbcbbe into main Oct 25, 2024
18 checks passed
@clux clux deleted the fix-custom-client-tls-ex branch October 25, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-exclude changelog excluded prs docs unclear documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant