Added err validations

kube-tarian · May 3, 2024 · 6255396 · 6255396
1 parent 96f4285
commit 6255396
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/capten/agent/gin-api-server/server.go b/capten/agent/gin-api-server/server.go
@@ -8,9 +8,9 @@ import (
 	"github.com/kube-tarian/kad/capten/agent/internal/config"
 )
 
-func StartRestServer(rpcapi api.ServerInterface, cfg *config.SericeConfig, certFileName, keyFileName string) {
+func StartRestServer(rpcapi api.ServerInterface, cfg *config.SericeConfig, certFileName, keyFileName string) error {
 	r := gin.Default()
 	api.RegisterHandlers(r, rpcapi)
 
-	r.RunTLS(fmt.Sprintf("%s:%d", cfg.Host, cfg.RestPort), certFileName, keyFileName)
+	return r.RunTLS(fmt.Sprintf("%s:%d", cfg.Host, cfg.RestPort), certFileName, keyFileName)
 }
diff --git a/capten/agent/internal/app/app.go b/capten/agent/internal/app/app.go
@@ -92,7 +92,13 @@ func Start() {
 	if err != nil {
 		log.Fatalf("Failed to setupt CA Cert Issuer in cert-manager %v", err)
 	}
-	go ginapiserver.StartRestServer(rpcapi, cfg, certFileName, keyFileName)
+
+	go func() {
+		err := ginapiserver.StartRestServer(rpcapi, cfg, certFileName, keyFileName)
+		if err != nil {
+			log.Errorf("Failed to start REST server, %v", err)
+		}
+	}()
 
 	err = registerK8SWatcher(as)
 	if err != nil {

diff --git a/capten/agent/internal/app/ca_cert_issuer.go b/capten/agent/internal/app/ca_cert_issuer.go
@@ -19,8 +19,8 @@ import (
 )
 
 const (
-	certFileName         = "server.cert"
-	keyFileName          = "server.key"
+	certFileName         = "/tmp/server.cert"
+	keyFileName          = "/tmp/server.key"
 	namespace            = "capten"
 	serverCertSecretName = "agent-server-mtls"
 )