Initial changes for configure SSO for APPs from server #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vramk23
requested changes
Aug 18, 2023
server/main.go
Outdated
| @@ -0,0 +1,72 @@ | |||
| package main | |||
There was a problem hiding this comment.
don't commit this test code, if needed keep it in examples
server/pkg/api/cluster_apps.go
Outdated
| clientID, clientSecret, err := s.iam.GetSecrets(ctx, app.Config.AppName, app.Config.LaunchURL) | ||
| if err != nil { | ||
| s.log.Error("failed to get secrets from IAM for %s, err :%v", app.Config.AppName, err) | ||
| return err |
There was a problem hiding this comment.
don't need to write error log when error is returned, caller support to log err
| s.log.Error("failed to get cluster application from agent", err) | ||
| return &serverpb.NewClusterRegistrationResponse{Status: serverpb.StatusCode_INTERNRAL_ERROR, | ||
| StatusMessage: "failed to get cluster application from agent"}, nil | ||
| } |
There was a problem hiding this comment.
should call GetLaunchUIConfig API instead of GetClusterApps
server/pkg/api/cluster_apps.go
Outdated
| if err != nil { | ||
| s.log.Error("failed to connect to agent", err) | ||
| return err | ||
| } |
There was a problem hiding this comment.
agent is already fetched in the registration, same can be reused passing the agent
server/pkg/api/cluster_apps.go
Outdated
|
|
||
| // Invoke IAM module and get the creds. | ||
| // What should be the client Name unique?? | ||
| clientID, clientSecret, err := s.iam.GetSecrets(ctx, app.Config.AppName, app.Config.LaunchURL) |
There was a problem hiding this comment.
method should named RegisterAppAsClient
| CredIdentifier: "", | ||
| Credential: map[string]string{}, | ||
| }) | ||
|
|
There was a problem hiding this comment.
fill the cred entityname and others from ENV
vramk23
approved these changes
Aug 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few code changes needed post discussion will update