Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding app template values #208

Merged
merged 1 commit into from
Sep 1, 2023
Merged

adding app template values #208

merged 1 commit into from
Sep 1, 2023

Conversation

vramk23
Copy link
Collaborator

@vramk23 vramk23 commented Aug 28, 2023

No description provided.

@@ -29,20 +29,19 @@
if appExists {
query = &pb.Query{
Cql: fmt.Sprintf(updateAppConfigQuery,
a.keyspace, config.ChartName, config.RepoName, config.RepoURL, config.Namespace, config.CreateNamespace, config.PrivilegedNamespace, config.LaunchURL, config.LaunchUIDescription, config.Category, config.Icon, config.Description, config.LaunchUIValues, config.OverrideValues, time.Now().Format("2006-01-02 15:04:05"), config.AppName, config.Version),
a.keyspace, config.ChartName, config.RepoName, config.RepoURL, config.Namespace, config.CreateNamespace, config.PrivilegedNamespace, config.LaunchURL, config.LaunchUIDescription, config.Category, config.Icon, config.Description, config.LaunchUIValues, config.OverrideValues, config.TemplateValues, time.Now().Format(time.RFC3339), config.AppName, config.Version),

Check failure

Code scanning / CodeQL

Potentially unsafe quoting Critical

If this
JSON value
contains a single quote, it could break out of the enclosing quotes.
@@ -29,20 +29,19 @@
if appExists {
query = &pb.Query{
Cql: fmt.Sprintf(updateAppConfigQuery,
a.keyspace, config.ChartName, config.RepoName, config.RepoURL, config.Namespace, config.CreateNamespace, config.PrivilegedNamespace, config.LaunchURL, config.LaunchUIDescription, config.Category, config.Icon, config.Description, config.LaunchUIValues, config.OverrideValues, time.Now().Format("2006-01-02 15:04:05"), config.AppName, config.Version),
a.keyspace, config.ChartName, config.RepoName, config.RepoURL, config.Namespace, config.CreateNamespace, config.PrivilegedNamespace, config.LaunchURL, config.LaunchUIDescription, config.Category, config.Icon, config.Description, config.LaunchUIValues, config.OverrideValues, config.TemplateValues, time.Now().Format(time.RFC3339), config.AppName, config.Version),

Check failure

Code scanning / CodeQL

Potentially unsafe quoting Critical

If this
JSON value
contains a single quote, it could break out of the enclosing quotes.
}
} else {
query = &pb.Query{
Cql: fmt.Sprintf(createAppConfigQuery,
a.keyspace, config.AppName, config.ChartName, config.RepoName, config.ReleaseName, config.RepoURL, config.Namespace, config.Version, config.CreateNamespace, config.PrivilegedNamespace, config.LaunchURL, config.LaunchUIDescription, config.Category, config.Icon, config.Description, config.LaunchUIValues, config.OverrideValues, time.Now().Format("2006-01-02 15:04:05"), uuid.New().String()),
a.keyspace, config.AppName, config.ChartName, config.RepoName, config.ReleaseName, config.RepoURL, config.Namespace, config.Version, config.CreateNamespace, config.PrivilegedNamespace, config.LaunchURL, config.LaunchUIDescription, config.Category, config.Icon, config.Description, config.LaunchUIValues, config.OverrideValues, config.TemplateValues, time.Now().Format(time.RFC3339), uuid.New().String()),

Check failure

Code scanning / CodeQL

Potentially unsafe quoting Critical

If this
JSON value
contains a single quote, it could break out of the enclosing quotes.
}
} else {
query = &pb.Query{
Cql: fmt.Sprintf(createAppConfigQuery,
a.keyspace, config.AppName, config.ChartName, config.RepoName, config.ReleaseName, config.RepoURL, config.Namespace, config.Version, config.CreateNamespace, config.PrivilegedNamespace, config.LaunchURL, config.LaunchUIDescription, config.Category, config.Icon, config.Description, config.LaunchUIValues, config.OverrideValues, time.Now().Format("2006-01-02 15:04:05"), uuid.New().String()),
a.keyspace, config.AppName, config.ChartName, config.RepoName, config.ReleaseName, config.RepoURL, config.Namespace, config.Version, config.CreateNamespace, config.PrivilegedNamespace, config.LaunchURL, config.LaunchUIDescription, config.Category, config.Icon, config.Description, config.LaunchUIValues, config.OverrideValues, config.TemplateValues, time.Now().Format(time.RFC3339), uuid.New().String()),

Check failure

Code scanning / CodeQL

Potentially unsafe quoting Critical

If this
JSON value
contains a single quote, it could break out of the enclosing quotes.
@vramk23 vramk23 force-pushed the template-values-add branch 5 times, most recently from ca4a51a to cdb0497 Compare September 1, 2023 18:02
@vramk23 vramk23 merged commit 2778fe6 into main Sep 1, 2023
7 of 8 checks passed
@vramk23 vramk23 deleted the template-values-add branch April 3, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant