Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CI): add a workflow to push multiubuntu image on any change #1968

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

Manik2708
Copy link
Contributor

@Manik2708 Manik2708 commented Feb 10, 2025

Purpose of PR?:

Fixes #1876

Does this PR introduce a breaking change? No

If the changes in this PR are manually verified, list down the scenarios covered::

Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Bug fix. Fixes #
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Commit has unit tests
  • Commit has integration tests

@Manik2708
Copy link
Contributor Author

@rksharma95 @Aryan-sharma11 Please review this, as the previous PR had to closed due to uncertain reasons!

@Manik2708
Copy link
Contributor Author

@rksharma95 @Aryan-sharma11 go-vuln is asking for upgrading go from 1.23.5 to 1.23.6

@rksharma95
Copy link
Collaborator

@rksharma95 @Aryan-sharma11 go-vuln is asking for upgrading go from 1.23.5 to 1.23.6

Let's upgrade to 1.23.6

@Manik2708
Copy link
Contributor Author

@rksharma95 That again might lead to snyk failures, should I proceed forward?

@rksharma95
Copy link
Collaborator

@rksharma95 That again might lead to snyk failures, should I proceed forward?

snyk failure can be ignored if it's due to version support issue. You can proceed with upgrade.

@Manik2708
Copy link
Contributor Author

@rksharma95 Upgraded to 1.23.6, please review

rksharma95
rksharma95 previously approved these changes Feb 12, 2025
Copy link
Collaborator

@rksharma95 rksharma95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

rootxrishabh
rootxrishabh previously approved these changes Feb 13, 2025
Copy link
Member

@rootxrishabh rootxrishabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Manik2708 Manik2708 dismissed stale reviews from rootxrishabh and rksharma95 via 400f145 February 13, 2025 13:58
@Manik2708 Manik2708 force-pushed the multiubuntu-ci branch 2 times, most recently from c5196bb to 16176e5 Compare February 13, 2025 13:59
Signed-off-by: Manik2708 <[email protected]>
@Manik2708
Copy link
Contributor Author

@rksharma95 @Aryan-sharma11 @rootxrishabh I have changed the ci-test-ubi-image.yml. Please review! Should I introduce a dummy change (which would be reverted when this PR will become ready to merge) to test the CI?

@rksharma95
Copy link
Collaborator

@rksharma95 @Aryan-sharma11 @rootxrishabh I have changed the ci-test-ubi-image.yml. Please review! Should I introduce a dummy change (which would be reverted when this PR will become ready to merge) to test the CI?

Not needed.

@rksharma95 rksharma95 merged commit 77d9cd5 into kubearmor:main Feb 14, 2025
19 checks passed
@Manik2708 Manik2708 deleted the multiubuntu-ci branch February 14, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add CI workflow to build and push multiubuntu image on change
4 participants