Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new member dandawg #736

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

dandawg
Copy link

@dandawg dandawg commented Jan 24, 2025

This PR adds dandawg as a new member of Kubeflow. The corresponding GitHub issue is: 735

Here is the output from the pytest run after my commit, which passed:

github-orgs % pytest test_org_yaml.py 
========================================================== test session starts ===========================================================
platform darwin -- Python 3.11.10, pytest-8.3.4, pluggy-1.5.0
rootdir: <omitted>/Code/Kubeflow/internal-acls/github-orgs
plugins: typeguard-4.4.1, anyio-4.7.0
collected 1 item                                                                                                                         

test_org_yaml.py .                                                                                                                 [100%]

=========================================================== 1 passed in 0.11s ============================================================

Signed-off-by: Daniel Dowler <[email protected]>
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign james-jwu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Hi @dandawg. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dandawg
Copy link
Author

dandawg commented Jan 24, 2025

I've worked with Kubeflow and the community a lot in the past as an ML implementer. Now, I'm finally joining as a contributor. Thank you reviewers!

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to endorse Daniel's membership.
/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants