Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improved membership request template #737

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 22 additions & 20 deletions .github/ISSUE_TEMPLATE/join_org.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,25 +6,27 @@ about: Request to join or modify Kubeflow GitHub membership

# Membership Request

Please read the [guidelines](https://www.kubeflow.org/docs/about/contributing/#joining-the-community) for joining the Kubeflow GitHub org before opening an issue

**Please provide links to PRs or other contributions (2-3):**

**Please list 2 existing members who are sponsoring your membership:**

## Please test your PR

Run

```bash
cd github_orgs
pytest test_org_yaml.py
```

Include the output in the PR
## Instructions
Please read the [guidelines](https://www.kubeflow.org/docs/about/contributing/#joining-the-community) for joining the Kubeflow GitHub org before opening an issue.

### Provide links to your PRs or other contributions (2-3):

### List 2 existing members who are sponsoring your membership:

### Create a new membership pull request (PR):
- Fork the [kubeflow/internals-acls](https://github.com/kubeflow/internal-acls/) repo and clone it locally.
- Modify [github-orgs/kubeflow/org.yaml](github-orgs/kubeflow/org.yaml) to include your GitHub username in the appropriate places.
- In the `org.kubeflow.members` list
- If you work for a company that is recognized by the Kubeflow project, then in your company team list (check `org.kubeflow.teams`)
- Test your code changes with:
```bash
cd github_orgs
pytest test_org_yaml.py
```
Confirm that the test run passed, and make sure to copy the test output so you can include it in your PR description (on GitHub).
- Push your changes to your `kubeflow/internals-acls` repository fork.
- Open a PR from the [kubeflow/internals-acls](https://github.com/kubeflow/internal-acls/) repo.

## Additional Instructions

After your PR is merged please wait at least 1 hour for changes to propogate.

If after an hour you haven't recieved an invite to join the GitHub org please open an issue.
- After your PR is merged please wait at least 1 hour for changes to propagate.
- If after an hour you haven't received an invite to join the GitHub org please open an issue.