Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(proposal): in-memory database without mlmd service #724

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Al-Pragliola
Copy link
Contributor

@Al-Pragliola Al-Pragliola commented Jan 21, 2025

Description

Builds on top of #425

In this proposal, I have added a new datastore as an alternative to mlmd for testing/development/static scenarios. This datastore acts as an in-memory database, it supports all actions possible on mlmd and specified in the openapi spec, and a seeding mechanism to have a common baseline in case of process exit/disturbance.

How Has This Been Tested?

docker build . -f Dockerfile -t docker.io/mr/mr:0.1.0

kind create cluster

kind load docker-image docker.io/mr/mr:0.1.0

kubectl create ns kubeflow

kubectl apply -k "./manifests/kustomize/overlays/inmemory"

kubectl patch deployment -n kubeflow model-registry-deployment --patch '{"spec": {"template": {"spec": {"containers": [{"name": "rest-container", "image": "mr/mr:0.1.0", "imagePullPolicy": "IfNotPresent"}]}}}}'

kubectl port-forward --namespace kubeflow svc/model-registry-service 8080:8080 &

curl -s -X 'POST' "localhost:8080/api/model_registry/v1alpha3/registered_models" -H 'accept: application/json' -H 'Content-Type: application/json' -d '{
      "description": "Iris scikit-learn model",
      "name": "iris"
}'

curl -s 'http://localhost:8080/api/model_registry/v1alpha3/registered_models?pageSize=100&orderBy=ID&sortOrder=DESC' -H 'accept: application/json' | jq

expected output:

{
  "items": [
    {
      "description": "loreum ipsum",
      "id": "1",
      "name": "test"
    },
    {
      "description": "loreum ipsum",
      "id": "2",
      "name": "test2"
    },
    {
      "description": "Iris scikit-learn model",
      "id": "3",
      "name": "iris",
      "state": "LIVE"
    }
  ],
  "nextPageToken": "",
  "pageSize": 1,
  "size": 3
}

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ckadner for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant