Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(ws): run make test-e2e on GitHub Actions #11

Merged
merged 5 commits into from
Aug 6, 2024

Conversation

jiridanek
Copy link
Member

This is something that works differently in new Kubebuilder, compared to what's in kubeflow/kubeflow notebook controller.

Previously, what they called e2e tests was running in envtest, but currently they expect to run in externally-provided kind. So, let's run this on CI as well, so we don't have dead code.

@jiridanek jiridanek changed the base branch from main to notebooks-v2 May 24, 2024 12:55
@google-oss-prow google-oss-prow bot added size/S and removed size/XXL labels May 24, 2024
@ederign
Copy link
Member

ederign commented May 29, 2024

/lgtm

@jiridanek
Copy link
Member Author

As per @thesuperzapper 's suggestion, I put in explicit kind version. Here's the CI running https://github.com/jiridanek/notebooks-v2/actions/runs/9602645980/job/26483942380

@thesuperzapper thesuperzapper added area/controller area - related to controller components project/notebooks-v2 project - kubeflow notebooks v2 area/ci area - related to ci labels Jul 18, 2024
@thesuperzapper thesuperzapper added this to the v2.0.0-alpha.0 milestone Jul 18, 2024
Signed-off-by: Mathew Wicks <[email protected]>
Signed-off-by: Mathew Wicks <[email protected]>
@google-oss-prow google-oss-prow bot added size/M and removed size/S labels Aug 6, 2024
@thesuperzapper
Copy link
Member

@jiridanek now that we have actual end-to-end tests (added in #30), I have rebased this PR and cleaned it up a little in 3e8beea and 7408921.

We should be good to merge now, so that tests run automatically on every PR for the controller.

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ederign, thesuperzapper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit e4e0aff into kubeflow:notebooks-v2 Aug 6, 2024
2 checks passed
@jiridanek jiridanek deleted the vjd_add_e2e-branch branch August 6, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/ci area - related to ci area/controller area - related to controller components lgtm project/notebooks-v2 project - kubeflow notebooks v2 size/M
Projects
Development

Successfully merging this pull request may close these issues.

3 participants