Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kustomize library #12

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add kustomize library #12

wants to merge 3 commits into from

Conversation

jiachengxu
Copy link
Contributor

@kubermatic-bot kubermatic-bot added the dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. label Jul 14, 2020
@kubermatic-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiachengxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 14, 2020
@kubermatic-bot
Copy link

kubermatic-bot commented Jul 14, 2020 •
edited
Loading

@jiachengxu: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-utils-lint 5a3e872 link /test pull-utils-lint

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

nmiculinic
nmiculinic suggested changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@nmiculinic nmiculinic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a bit more work:

  • adding test case
  • (maybe not in this PR) moving Nicos staticfs from private to utils repo
  • better PR description/commit messages

go.mod
@@ -2,6 +2,8 @@ module github.com/kubermatic/utils

go 1.14

replace k8s.io/client-go => k8s.io/client-go v0.18.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this needed? And it worked previously.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think kustomize somehow depends on client-go? because now code cannot be compiled due to some issues of k8s.io/client-go v11.0.0+incompatible, and in KubeCarrier we also override the version of client-go to make it properly.

pkg/kustomize/kustomize.go
"net/http"
"os"

statikfs "github.com/thetechnick/statik/fs"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, this should be moved to utils repo as well. It has no business being in private member repo.

pkg/kustomize/kustomize.go
@@ -0,0 +1,202 @@
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test for this file. In the test, you can use the fact the test working directory is set to the _test.go directory. And then you use http.Dir for accessing the test files (it implements the http.FileSystem interface, read the docs). No need for statik for test cases.

@kubermatic-bot kubermatic-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 25, 2020
@kubermatic-bot
Copy link

@jiachengxu: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nmiculinic nmiculinic removed their assignment Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmiculinic nmiculinic nmiculinic requested changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jiachengxu @kubermatic-bot @nmiculinic