Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golangci-lint to fix aws-sdk-go-v2 linting issues #122

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mjlshen
Copy link

@mjlshen mjlshen commented Oct 8, 2024

  • We have been pinning to older versions of many golangci-lint packages that are no longer needed
  • Updated golangci-lint to v1.61.0 and change a deprecated --deadline flag to --timeout
  • Resolve linter errors - mostly this is ignoring staticcheck for KMSv1 code that's being carried

Resolves CI linting failures in #120 but depends on #121 to merge first to fix a separate CI issue

* We have been pinning to older versions of many golangci-lint packages
  that are no longer needed
* Updated golangci-lint to v1.61.0 and change a deprecated --deadline
  flag to --timeout
* Resolve linter errors

Signed-off-by: Michael Shen <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 8, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mjlshen
Once this PR has been reviewed and has the lgtm label, please assign micahhausler for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 8, 2024
@mjlshen mjlshen changed the title Update golangci-lint Update golangci-lint to fix aws-sdk-go-v2 linting issues Oct 8, 2024
@k8s-ci-robot
Copy link
Contributor

@mjlshen: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-aws-encryption-provider-unittest a27e32c link true /test pull-aws-encryption-provider-unittest

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants