-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix dataplane loader #312
fix dataplane loader #312
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jokestax The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Rishi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for your contribution @jokestax we appreciate you joining us here 👋
I have a couple questions about the patch, let me know your thoughts?
@shaneutt ,yes, the issue is resolved. we can go ahead and close it. Thank you again for the quick response and fix 🙌 |
No thank you, sorry about the overlap! If there's other areas here you're interested in contributing to, please do feel free to reach out on |
Thank you! I'm already part of the community 😊 and very excited to contribute to the project. I'll definitely take up some tasks. I was playing around with it and was thinking of taking on this task: #25. Is that okay? |
Oh, yep! I see you joined the Slack already cool. Yes feel free to take a stab at that one, it's a bit old: if it seems kinda crunchy or if you need support please reach out in Slack. 🥂 |
Thanks a lot! I'll get started and reach out in Slack! |
Description
The error was
error cannot find value 'bpf-program' in this scope
,because the variablebpf_program
is only available whendebug_assertions
is enabled, so fixed it by using correct variable whether pogram is in release build or debug and also theinclude_bytes_aligned!
macro was unable to load the file at runtime. Replaced withfs::read()
to load the fileTesting
To test this change:
make build.image.dataplane
.