Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update for cluster-api 1.6 and kubernetes 1.28 #102

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

elmiko
Copy link
Contributor

@elmiko elmiko commented Jan 26, 2024

What this PR does / why we need it:

this change updates the dependencies for cluster-api, kubernetes and controller runtime.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged):
fixes #

Special notes for your reviewer:

Release notes:

Add support for Cluster API 1.6 and Kubernetes 1.28

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from vincepri January 26, 2024 20:50
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 26, 2024
@elmiko
Copy link
Contributor Author

elmiko commented Jan 26, 2024

still doing some local testing on this

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 26, 2024
@elmiko elmiko force-pushed the update-to-capi-1.6 branch from 8bc4fce to 44efc91 Compare January 29, 2024 01:40
@elmiko
Copy link
Contributor Author

elmiko commented Jan 29, 2024

preliminary testing with make test-e2e, need to fixup the templates to use kubernetes 1.28.

$ kubectl --kubeconfig /tmp/km.kubeconfig get nodes
NAME                        STATUS   ROLES           AGE     VERSION
km-cp-control-plane-dflb5   Ready    control-plane   4m31s   v1.27.3
km-wl-kubemark-md-0-dv4hz   Ready    <none>          4m19s   v1.27.3
km-wl-kubemark-md-0-nb7kx   Ready    <none>          4m20s   v1.27.3
km-wl-kubemark-md-0-rv8n9   Ready    <none>          4m19s   v1.27.3
km-wl-kubemark-md-0-xsc5h   Ready    <none>          4m19s   v1.27.3

this change updates the dependencies for cluster-api, kubernetes and
controller runtime.
@elmiko elmiko force-pushed the update-to-capi-1.6 branch from 44efc91 to 672a0fa Compare January 29, 2024 23:04
@elmiko
Copy link
Contributor Author

elmiko commented Feb 9, 2024

i've done more testing with 1.28 kubernetes, this is ready imo

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 9, 2024
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Haven't tested - but the changes look good to me.

As a heads up - for the CAPI 1.7 bump the api versions and cluster api imports will need to be bumped so it'll end up being a substantial change.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2024
@k8s-ci-robot k8s-ci-robot merged commit 26a8f36 into kubernetes-sigs:main Feb 9, 2024
5 checks passed
@elmiko
Copy link
Contributor Author

elmiko commented Feb 16, 2024

thanks for the heads up @killianmuldoon !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants