-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update for cluster-api 1.6 and kubernetes 1.28 #102
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elmiko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
still doing some local testing on this /hold |
8bc4fce
to
44efc91
Compare
preliminary testing with
|
this change updates the dependencies for cluster-api, kubernetes and controller runtime.
44efc91
to
672a0fa
Compare
i've done more testing with 1.28 kubernetes, this is ready imo /hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Haven't tested - but the changes look good to me.
As a heads up - for the CAPI 1.7 bump the api versions and cluster api imports will need to be bumped so it'll end up being a substantial change.
thanks for the heads up @killianmuldoon ! |
What this PR does / why we need it:
this change updates the dependencies for cluster-api, kubernetes and controller runtime.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged):fixes #
Special notes for your reviewer:
Release notes: