update to Cluster api 1.7 #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this change brings the provider into line with the cluster-api 1.7 release, and also with kubernetes 1.29
it appears that a change in the cluster-api kubeadm bootstrap provider is causing secrets with the same name as a machine to be created in the namespace with the machine object. this is causing the kubeconfig secret created by the capk controller to be overwritten, which cascades into kubemark not being able to start. the fix is to add "kubemark-config" as a suffix to secret.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elmiko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/assign |
nrb
reviewed
Sep 13, 2024
| @@ -5,7 +5,7 @@ jobs: | |||
| if: (github.repository == 'kubernetes-sigs/cluster-api-provider-kubemark') | |||
| strategy: | |||
| matrix: | |||
| go-version: [1.22.x] | |||
| go-version: [1.21.x] | |||
There was a problem hiding this comment.
i was mostly trying to sync all the versions so that everything was the same, my plan is to update to 1.22 with the cluster-api 1.8 update. so, mostly just trying to get a clean base to build on top of.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
updates the provider to use 1.7 capi and 1.29 k8s.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged):fixes #106
Special notes for your reviewer:
use
make test-e2eto replicatei tested this locally on an ubuntu 22.04 server and got the following output:
Release notes: