Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GCP tags UTs to not look for auth #905

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bharath-b-rh
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Unit tests written for GCP tags was expecting the creds to be present which should not be case and hence the dependency is removed. And instead for UTs WithoutAuthentication is used.

Which issue(s) this PR fixes:

Fixes

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 15, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @bharath-b-rh. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bharath-b-rh
Once this PR has been reviewed and has the lgtm label, please assign saikat-royc for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bharath-b-rh
Copy link
Contributor Author

@mattcary Could I request your review, PTAL. Thank you in advance!

@leiyiz
Copy link
Contributor

leiyiz commented Jul 31, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 31, 2024
@bharath-b-rh
Copy link
Contributor Author

@leiyiz Could you please add cherry-pick release-1.6 label too, if the changes are satisfactory.

@bharath-b-rh
Copy link
Contributor Author

@leiyiz ^^

@mattcary
Copy link
Contributor

mattcary commented Aug 6, 2024

Hi, similar to what I said on the cherry-pick CL, is this necessary to cherry-pick?

@bharath-b-rh
Copy link
Contributor Author

Hi, similar to what I said on the cherry-pick CL, is this necessary to cherry-pick?

Yeah, this would be helpful to check unit tests in environment where GCP auth is not provided and since the changes are specific to unit tests, it will not change the actual behavior.

@mattcary
Copy link
Contributor

mattcary commented Aug 6, 2024

Yeah, this would be helpful to check unit tests in environment where GCP auth is not provided and since the changes are specific to unit tests, it will not change the actual behavior.

Ok, we'll have to take a close look, the GKE backport policy is strict.

@bharath-b-rh
Copy link
Contributor Author

Yeah, this would be helpful to check unit tests in environment where GCP auth is not provided and since the changes are specific to unit tests, it will not change the actual behavior.

Ok, we'll have to take a close look, the GKE backport policy is strict.

Thank you!

@bharath-b-rh
Copy link
Contributor Author

@leiyiz Could you please take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants