-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GCP tags UTs to not look for auth #905
base: master
Are you sure you want to change the base?
Conversation
Hi @bharath-b-rh. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bharath-b-rh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mattcary Could I request your review, PTAL. Thank you in advance! |
/ok-to-test |
@leiyiz Could you please add |
@leiyiz ^^ |
Hi, similar to what I said on the cherry-pick CL, is this necessary to cherry-pick? |
Yeah, this would be helpful to check unit tests in environment where GCP auth is not provided and since the changes are specific to unit tests, it will not change the actual behavior. |
Ok, we'll have to take a close look, the GKE backport policy is strict. |
Thank you! |
@leiyiz Could you please take a look. |
What type of PR is this?
What this PR does / why we need it:
Unit tests written for GCP tags was expecting the creds to be present which should not be case and hence the dependency is removed. And instead for UTs
WithoutAuthentication
is used.Which issue(s) this PR fixes:
Fixes
Special notes for your reviewer:
Does this PR introduce a user-facing change?: