Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix nil pointer dereference #1954

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore: fix nil pointer dereference #1954

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/controllers/state/cluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,7 +547,7 @@ func (c *Cluster) newStateFromNode(ctx context.Context, node *corev1.Node, oldNo

func (c *Cluster) cleanupNode(name string) {
if id := c.nodeNameToProviderID[name]; id != "" {
if c.nodes[id].NodeClaim == nil {
if c.nodes[id] != nil && c.nodes[id].NodeClaim == nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should understand the scenarios that this can occur under before we just ignore these cases -- it seems odd to me that we would get into this state but maybe this can happen when we have two nodes with the same providerID?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on discussion in triage meeting, this could possibly be the node name instead?

delete(c.nodes, id)
} else {
c.nodes[id].Node = nil
Expand Down
Loading