-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support kube-proxy nftables mode #3577
Conversation
/cc @danwinship |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@BenTheElder the problem with this option is to keep compatibility with old version, as it only will work with new versions ... I can't remember if we have some precedent like this |
This is true with feature gates, not exactly the same as those are totally user supplied strings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, we will need to internally version-check at cluster config time anyhow and enable NFTablesProxyMode feature gate? Or do we expect the user to do this?
It's new that we have our own config option for an alpha feature.
no, you missed:
|
Sorry, yes, SGTM. I think we should just document that it's 1.31+, we allow clusters with mixed versions and only advanced users will be setting this field anyhow. |
Co-authored-by: Benjamin Elder <[email protected]>
/hold cancel K/K PR is already merged and this will allow to set up CI without having to use additional scripting kubernetes/kubernetes#124383 |
/lgtm |
/hold
wait until 1.31 graduates it to beta
Fixes: #3434