-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new directory/remote builder - new modes to specify k8s binaries to build node-images #3614
Add a new directory/remote builder - new modes to specify k8s binaries to build node-images #3614
Conversation
built an image using:
and looks like that does build the node image properly
|
5067065
to
7df6883
Compare
7df6883
to
6e0fb3c
Compare
/retest |
@BenTheElder @aojea here's what i came up with. Please verify if we can go with this.
|
6e0fb3c
to
9755509
Compare
@stmcginnis @aojea @BenTheElder here are the latest command lines i tested. If these are good, then i'll update the docs in this PR itself.
|
This looks reasonable to me - thanks @dims! |
d369c8c
to
77129f5
Compare
Updated docs and CLI help. thanks @stmcginnis @aojea @BenTheElder PTAL |
0f06d1c
to
b197196
Compare
@BenTheElder is |
b197196
to
9adb5ec
Compare
/lgtm |
thanks @aojea ! /assign @BenTheElder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see this being very useful!
/lgtm
Signed-off-by: Davanum Srinivas <[email protected]> Co-authored-by: Antonio Ojea <[email protected]> Signed-off-by: Davanum Srinivas <[email protected]>
9adb5ec
to
e29f332
Compare
Thanks @dims! /lgtm |
/test pull-kind-e2e-kubernetes-1-29 |
yeah, that sounds like a failed download or bad binfmt_misc, we have some flakes in these jobs with the environment and some flakes in prow with the e2e tests (like #3609, still waiting for those backports to merge) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
thanks dims! 🎉
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, dims The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi, this is a kind v0.24.0 feature, right? Any thought when this will be release. Thanks! |
It is. When we're ready. There are other essentials to sort out and all of us only work on kind part time so no particular ETA. you can install kind @ HEAD with the makefile, instructions in the docs, but it won't be fully supported yet and we may make some changes before releasing. |
Related to #381
Enabling the following command lines to build node image
This is aimed at someone who may have a different build system and do not use the k8s make file targets, but would love to build a node image for kind with their own patches and build systems
This is aimed at the majority of the current requests on slack and other avenues who just want to play with a version we haven't created a node image for (but has an upstream k8s tag and release artifacts)
Please take a look!
Here are the list of files and directory structure needed by the new builder in the tar gzipped file (including the
kubernetes
directory. which should be at the root of the passed in root directory)With this PR, here are some of the possibilities: