Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Port-10250 to default kubeadm_ignore_preflight_errors #11900

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Port-10250 to default kubeadm_ignore_preflight_errors #11900

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion roles/kubernetes/kubeadm_common/defaults/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,5 @@ kubeadm_patches: []
# Patches are applied in the order they are specified.

# List of errors to ignore during kubeadm preflight checks
kubeadm_ignore_preflight_errors: []
kubeadm_ignore_preflight_errors:
- Port-10250
Comment on lines -23 to +24
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can't be done here because this would break customization of this variable.
It should instead be done locally on the task experiencing the issue, like :

kubespray/roles/kubernetes/kubeadm/tasks/main.yml

Lines 87 to 96 in 0e91000

vars:
ignored:
- DirAvailable--etc-kubernetes-manifests
- "{{ kubeadm_ignore_preflight_errors }}"
command: >-
timeout -k {{ kubeadm_join_timeout }} {{ kubeadm_join_timeout }}
{{ bin_dir }}/kubeadm join
--config {{ kube_config_dir }}/kubeadm-client.conf
--ignore-preflight-errors={{ ignored | flatten | join(',') }}
--skip-phases={{ kubeadm_join_phases_skip | join(',') }}

Or if this affect several tasks, have another variables which is combined to form the full list at the relevant use sites.