add default value to EtcdQuotaBackendSize

kubernetes-sigs · Sep 14, 2024 · 8876240 · 8876240
1 parent b3c1d2b
commit 8876240
Show file tree

Hide file tree

Showing 9 changed files with 15 additions and 1 deletion.
diff --git a/pkg/apis/config/v1alpha1/kwokctl_configuration_types.go b/pkg/apis/config/v1alpha1/kwokctl_configuration_types.go
@@ -454,6 +454,7 @@ type KwokctlConfigurationOptions struct {
 	DisableQPSLimits *bool `json:"disableQPSLimits,omitempty"`
 
 	// EtcdQuotaBackendSize is the backend quota for etcd.
+	// +default="8Gi"
 	EtcdQuotaBackendSize string `json:"etcdQuotaBackendSize,omitempty"`
 }
 

diff --git a/pkg/apis/config/v1alpha1/zz_generated.defaults.go b/pkg/apis/config/v1alpha1/zz_generated.defaults.go
diff --git a/site/content/en/docs/generated/kwokctl_create_cluster.md b/site/content/en/docs/generated/kwokctl_create_cluster.md
@@ -25,7 +25,7 @@ kwokctl create cluster [flags]
                                                  (default "registry.k8s.io/etcd:3.5.15-0")
       --etcd-port uint32                        Port of etcd given to the host. The behavior is unstable for kind/kind-podman runtime and may be modified in the future
       --etcd-prefix string                      prefix of the key (default "/registry")
-      --etcd-quota-backend-size string          Quota backend size for etcd
+      --etcd-quota-backend-size string          Quota backend size for etcd (default "8Gi")
       --extra-args component=key=value          Pass a single extra arg key-value pair to the component in the format component=key=value
       --heartbeat-factor float                  Scale factor for all about heartbeat (default 5)
   -h, --help                                    help for cluster

diff --git a/test/e2e/kwokctl/dryrun/testdata/kind-podman/create_cluster.txt b/test/e2e/kwokctl/dryrun/testdata/kind-podman/create_cluster.txt
@@ -25,6 +25,8 @@ kubeadmConfigPatches:
   etcd:
     local:
       dataDir: /var/lib/etcd
+      extraArgs:
+        quota-backend-bytes: "8589934592"
   kind: ClusterConfiguration
   networking: {}
   scheduler:

diff --git a/test/e2e/kwokctl/dryrun/testdata/kind-podman/create_cluster_with_extra.txt b/test/e2e/kwokctl/dryrun/testdata/kind-podman/create_cluster_with_extra.txt
@@ -39,6 +39,7 @@ kubeadmConfigPatches:
       dataDir: /var/lib/etcd
       extraArgs:
         log-level: debug
+        quota-backend-bytes: "8589934592"
   kind: ClusterConfiguration
   networking: {}
   scheduler:

diff --git a/test/e2e/kwokctl/dryrun/testdata/kind-podman/create_cluster_with_verbosity.txt b/test/e2e/kwokctl/dryrun/testdata/kind-podman/create_cluster_with_verbosity.txt
@@ -57,6 +57,8 @@ kubeadmConfigPatches:
   etcd:
     local:
       dataDir: /var/lib/etcd
+      extraArgs:
+        quota-backend-bytes: "8589934592"
   kind: ClusterConfiguration
   networking: {}
   scheduler:

diff --git a/test/e2e/kwokctl/dryrun/testdata/kind/create_cluster.txt b/test/e2e/kwokctl/dryrun/testdata/kind/create_cluster.txt
@@ -25,6 +25,8 @@ kubeadmConfigPatches:
   etcd:
     local:
       dataDir: /var/lib/etcd
+      extraArgs:
+        quota-backend-bytes: "8589934592"
   kind: ClusterConfiguration
   networking: {}
   scheduler:

diff --git a/test/e2e/kwokctl/dryrun/testdata/kind/create_cluster_with_extra.txt b/test/e2e/kwokctl/dryrun/testdata/kind/create_cluster_with_extra.txt
@@ -39,6 +39,7 @@ kubeadmConfigPatches:
       dataDir: /var/lib/etcd
       extraArgs:
         log-level: debug
+        quota-backend-bytes: "8589934592"
   kind: ClusterConfiguration
   networking: {}
   scheduler:

diff --git a/test/e2e/kwokctl/dryrun/testdata/kind/create_cluster_with_verbosity.txt b/test/e2e/kwokctl/dryrun/testdata/kind/create_cluster_with_verbosity.txt
@@ -57,6 +57,8 @@ kubeadmConfigPatches:
   etcd:
     local:
       dataDir: /var/lib/etcd
+      extraArgs:
+        quota-backend-bytes: "8589934592"
   kind: ClusterConfiguration
   networking: {}
   scheduler: