Add field of override for component extraArgs

[liangyuanpeng]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

I'm using componentsPatches to rewrite the args of kube-apiserver for etcd-servers and etcd-prefix, it's working for me but i found the arg etcd-servers and etcd-prefix is repeated. This PR is working for cleanup the repeate.

config.yaml

kind: KwokctlConfiguration
apiVersion: config.kwok.x-k8s.io/v1alpha1
componentsPatches:
- name: kube-apiserver
  extraArgs:
  - key: etcd-servers
    value: http://192.168.66.2:3379
  - key: etcd-prefix
    value: /test

cmd of container kube-apiserver

                "--etcd-prefix=/registry",
                "--allow-privileged=true",
                "--etcd-servers=http://kwok-kwok-etcd:2379",
...
                "--etcd-servers=http://192.168.66.2:3379",
                "--etcd-prefix=/test"

/assign @wzshiming

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

support override filed for extraArg.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

Welcome @liangyuanpeng!

It looks like this is your first PR to kubernetes-sigs/kwok 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kwok has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @liangyuanpeng. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for k8s-kwok canceled.

Name	Link
🔨 Latest commit	43df963
🔍 Latest deploy log	https://app.netlify.com/sites/k8s-kwok/deploys/66bede2023b9070008cf6d14

[liangyuanpeng]

/release-note none

[wzshiming]

I think we can add an override field to ExtraArgs to override hardcode args.

[liangyuanpeng]

I think we can add an override field to ExtraArgs to override hardcode args.

@wzshiming
Do you mean add a arg like override=true into ExtraArgs? and for user, they need write something like :

componentsPatches:
- name: kube-apiserver
  extraArgs:
  - key: etcd-servers
    value: http://192.168.66.2:3379
  - key: etcd-prefix
    value: /test
  - key: override 
    value:  true

and do not override args by default.

[wzshiming]

I think it looks like this.

When the override is true, the same key arguments that already exist are removed.

componentsPatches:
- name: kube-apiserver
  extraArgs:
  - key: etcd-servers
    value: http://192.168.66.2:3379
    override: true
  - key: etcd-prefix
    value: /test
    override: true

or another way to remove existing arguments

componentsPatches:
- name: kube-apiserver
  extraArgs:
  - key: etcd-servers
    remove: true
  - key: etcd-prefix
    remove: true
  - key: etcd-servers
    value: http://192.168.66.2:3379
  - key: etcd-prefix
    value: /test

[wzshiming]

It might be better to have hard-coded expectation output.

[liangyuanpeng]

should, let me update it for test data for want later

[wzshiming]

@liangyuanpeng

I think the override may need to be used in a different way without sort args,
I worry sort args will lead to unexpected patch args in the future.
WDYT?

[liangyuanpeng]

@wzshiming ready to go!

[liangyuanpeng]

/remove-kind cleanup
/kind feature

[wzshiming]

/ok-to-test

[wzshiming]

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liangyuanpeng, wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [wzshiming]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[wzshiming]

/override pull-kwok-e2e-test-main

[k8s-ci-robot]

@wzshiming: Overrode contexts on behalf of wzshiming: pull-kwok-e2e-test-main

In response to this:

/override pull-kwok-e2e-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.