Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kwokctl] Support for exposing component ports #1203

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

wzshiming
Copy link
Member

@wzshiming wzshiming commented Aug 26, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1036
Fixes #1035

Special notes for your reviewer:

Does this PR introduce a user-facing change?

[kwokctl] Add `port-forward` subcommand for exposing component port

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2024
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 26, 2024
Copy link

netlify bot commented Aug 26, 2024

Deploy Preview for k8s-kwok canceled.

Name Link
🔨 Latest commit ed43f16
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/66d09259f6ad9a00082fea66

@wzshiming wzshiming force-pushed the feat/expose-port branch 10 times, most recently from 75189a1 to f3b23f6 Compare August 26, 2024 13:26
@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Aug 26, 2024
@wzshiming wzshiming force-pushed the feat/expose-port branch 3 times, most recently from 44eda87 to 93ad2b2 Compare August 26, 2024 15:39
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 27, 2024
@wzshiming wzshiming force-pushed the feat/expose-port branch 6 times, most recently from 1ac7af4 to d345f92 Compare August 27, 2024 06:43
@wzshiming wzshiming force-pushed the feat/expose-port branch 19 times, most recently from 9f302df to 298e29d Compare August 29, 2024 07:51
@wzshiming wzshiming merged commit f80b5ba into kubernetes-sigs:main Aug 30, 2024
25 of 26 checks passed
@wzshiming wzshiming deleted the feat/expose-port branch August 30, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[kwokctl] Support for exposing component ports to hosts in container executing Expose etcd port unexpected
2 participants