Fix broken links dependency for prometheus component

[chotiwat]

What type of PR is this?

/kind bug

What this PR does / why we need it:

I've encountered the below error when prometheus is enabled but kube-scheduler is disabled. Specifically, I was trying to enable prometheus for kube-scheduler-simulator so this issue is reproducible by setting options.prometheusPort to 9090 in https://github.com/kubernetes-sigs/kube-scheduler-simulator/blob/6cce7f41e06d3a419188f689264387d937c8b460/kwok.yaml.

{"time":"2024-09-17T01:40:26.594777384Z","level":"ERROR","source":{"function":"main.main","file":"/workspace/cmd/kwokctl/main.go","line":54},"msg":"Execute exit","err":"failed to start cluster \"kwok-kwok\": broken links dependency detected: [prometheus]"}

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

Welcome @chotiwat!

It looks like this is your first PR to kubernetes-sigs/kwok 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kwok has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @chotiwat. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for k8s-kwok canceled.

Name	Link
🔨 Latest commit	c4da342
🔍 Latest deploy log	https://app.netlify.com/sites/k8s-kwok/deploys/66ea983157c69c000788372b

[wzshiming]

/ok-to-test

[chotiwat]

/retest

[wzshiming]

Please run ./hack/update-testdata.sh to update the test data

[wzshiming]

Revert this

[chotiwat]

Why did this happen, even on the clean main branch?

[wzshiming]

https://kwok.sigs.k8s.io/docs/user/kwokctl-platform-specific-binaries/

k8s doesn't officially provide Darwin binaries, the binary runtime under Darwin uses unofficial builds on https://github.com/kwok-ci/k8s by default.

[wzshiming]

please squash commits

[wzshiming]

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chotiwat, wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [wzshiming]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[wzshiming]

/cherrypick release-0.6

[k8s-infra-cherrypick-robot]

@wzshiming: #1225 failed to apply on top of branch "release-0.6":

Applying: Fix broken links dependency for prometheus component
Using index info to reconstruct a base tree...
M	pkg/kwokctl/components/prometheus.go
M	pkg/kwokctl/runtime/binary/cluster.go
M	pkg/kwokctl/runtime/compose/cluster.go
M	pkg/kwokctl/runtime/kind/cluster.go
M	test/e2e/kwokctl/dryrun/testdata/docker/create_cluster_with_extra.txt
M	test/e2e/kwokctl/dryrun/testdata/docker/create_cluster_with_verbosity.txt
M	test/e2e/kwokctl/dryrun/testdata/podman/create_cluster_with_extra.txt
M	test/e2e/kwokctl/dryrun/testdata/podman/create_cluster_with_verbosity.txt
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/kwokctl/dryrun/testdata/podman/create_cluster_with_verbosity.txt
CONFLICT (content): Merge conflict in test/e2e/kwokctl/dryrun/testdata/podman/create_cluster_with_verbosity.txt
Auto-merging test/e2e/kwokctl/dryrun/testdata/podman/create_cluster_with_extra.txt
CONFLICT (content): Merge conflict in test/e2e/kwokctl/dryrun/testdata/podman/create_cluster_with_extra.txt
Auto-merging test/e2e/kwokctl/dryrun/testdata/docker/create_cluster_with_verbosity.txt
CONFLICT (content): Merge conflict in test/e2e/kwokctl/dryrun/testdata/docker/create_cluster_with_verbosity.txt
Auto-merging test/e2e/kwokctl/dryrun/testdata/docker/create_cluster_with_extra.txt
CONFLICT (content): Merge conflict in test/e2e/kwokctl/dryrun/testdata/docker/create_cluster_with_extra.txt
Auto-merging pkg/kwokctl/runtime/kind/cluster.go
Auto-merging pkg/kwokctl/runtime/compose/cluster.go
Auto-merging pkg/kwokctl/runtime/binary/cluster.go
Auto-merging pkg/kwokctl/components/prometheus.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Fix broken links dependency for prometheus component

In response to this:

/cherrypick release-0.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.