Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kwokctl] Add metrics for components #853

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

wzshiming
Copy link
Member

@wzshiming wzshiming commented Nov 24, 2023

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

[kwokctl] Add metrics for components

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels Nov 24, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

netlify bot commented Nov 24, 2023

Deploy Preview for k8s-kwok canceled.

Name Link
🔨 Latest commit 67ae9bd
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/6576d7b28316880008b69d22

@k8s-ci-robot k8s-ci-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Nov 24, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 24, 2023
@wzshiming wzshiming force-pushed the feat/components-metrics branch 2 times, most recently from 395e97e to a6f967c Compare November 24, 2023 04:21
@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Nov 24, 2023
@wzshiming wzshiming force-pushed the feat/components-metrics branch 9 times, most recently from e869457 to 71dbea6 Compare November 30, 2023 12:02
@wzshiming wzshiming force-pushed the feat/components-metrics branch 2 times, most recently from 48a3325 to 40e9e6d Compare December 1, 2023 06:00
@wzshiming wzshiming changed the title [WIP] Feature components metrics [WIP] [kwokctl] Add metrics for components Dec 8, 2023
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 8, 2023
@wzshiming wzshiming force-pushed the feat/components-metrics branch 2 times, most recently from 1d6715b to 87b2ead Compare December 11, 2023 09:06
@wzshiming wzshiming changed the title [WIP] [kwokctl] Add metrics for components [kwokctl] Add metrics for components Dec 12, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 12, 2023
@wzshiming wzshiming merged commit df21672 into kubernetes-sigs:main Dec 12, 2023
29 of 30 checks passed
@wzshiming wzshiming deleted the feat/components-metrics branch December 12, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/documentation Categorizes issue or PR as related to documentation. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants