Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kwokctl] Shorten the default node lease #857

Merged
merged 1 commit into from
Dec 6, 2023
Merged

[kwokctl] Shorten the default node lease #857

merged 1 commit into from
Dec 6, 2023

Conversation

wzshiming
Copy link
Member

@wzshiming wzshiming commented Nov 29, 2023 •
edited
Loading

What type of PR is this?

/kind bug
/kind feature
/kind api-change

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

[broken] Shorten the default node lease
Add a flag `--node-lease-duration-seconds` to modify the default node lease
Fix node is not managed for a long time after the restart
Fix snapshot with etcd

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Nov 29, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 29, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify Netlify
Copy link

netlify bot commented Nov 29, 2023 •
edited
Loading

✅ Deploy Preview for k8s-kwok canceled.

Name Link
🔨 Latest commit 4e0291f
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/65700711eb001b00095c948f

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 29, 2023
@wzshiming wzshiming force-pushed the about-lease branch 2 times, most recently from eccb3b8 to cadac2d Compare November 29, 2023 13:15
@wzshiming wzshiming changed the title Fix snapshot and shorten the default node lease [kwokctl] Shorten the default node lease Nov 29, 2023
@wzshiming wzshiming force-pushed the about-lease branch 12 times, most recently from 7f67177 to 95e2cda Compare November 30, 2023 09:53
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 30, 2023
@wzshiming wzshiming force-pushed the about-lease branch 19 times, most recently from 40eb177 to 547ff27 Compare December 5, 2023 15:33
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 5, 2023
@wzshiming wzshiming mentioned this pull request Dec 5, 2023
Closed
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 6, 2023
@wzshiming wzshiming merged commit 17e67ea into kubernetes-sigs:main Dec 6, 2023
27 of 29 checks passed
@wzshiming wzshiming deleted the about-lease branch December 6, 2023 06:17
@wzshiming wzshiming restored the about-lease branch December 6, 2023 06:17
@wzshiming wzshiming deleted the about-lease branch December 6, 2023 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Huang-Wei Huang-Wei Awaiting requested review from Huang-Wei

@yibozhuang yibozhuang Awaiting requested review from yibozhuang

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wzshiming @k8s-ci-robot