Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to set the kubernetes log level #378

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aojea
Copy link

@aojea aojea commented Oct 26, 2024

allow to configure the verbosity of the logs on the kubernetes components.

Ref kubernetes-sigs/kind#1750

Necessary to help debugging kubernetes/kubernetes#127721

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 26, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 26, 2024
@aojea
Copy link
Author

aojea commented Oct 26, 2024

/assign @dims

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aojea
Once this PR has been reviewed and has the lgtm label, please ask for approval from dims. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 27, 2024
@aojea
Copy link
Author

aojea commented Oct 27, 2024

I see

+ [[ false == true ]]
+ sed -i 's|{{BOOTSTRAP_TOKEN}}|eac9lf.w8pfcb1pvey46iow|g' /etc/kubernetes/kubeadm-join.yaml
+ sed -i 's|{{KUBEADM_CONTROL_PLANE_IP}}|172.31.19.193|g' /etc/kubernetes/kubeadm-join.yaml
+ kubeadm join --v 10 --config /etc/kubernetes/kubeadm-join.yaml
I1027 09:48:36.855288   16364 join.go:421] [preflight] found NodeName empty; using OS hostname as NodeName
I1027 09:48:36.855337   16364 joinconfiguration.go:83] loading configuration from "/etc/kubernetes/kubeadm-join.yaml"
could not interpret GroupVersionKind; unmarshal error: error converting YAML to JSON: yaml: invalid map key: map[interface {}]interface {}{"KUBE_LOG_LEVEL":interface {}(nil)}
+ [[ false == true ]]

it has to replace the log level always or it will not work

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 31, 2024
@aojea
Copy link
Author

aojea commented Oct 31, 2024

pushed a new version

allow to configure the verbosity of the logs on the kubernetes
components.

Change-Id: I1064f73277454ab5534201e69026684b5ff94199
@k8s-ci-robot
Copy link
Contributor

@aojea: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-ec2-quick 360f145 link true /test pull-kubernetes-e2e-ec2-quick
pull-kubernetes-e2e-ec2-cloud-provider-quick 360f145 link false /test pull-kubernetes-e2e-ec2-cloud-provider-quick
pull-kubernetes-e2e-ec2-cloud-provider-canary 360f145 link false /test pull-kubernetes-e2e-ec2-cloud-provider-canary
pull-kubernetes-e2e-ec2-conformance-canary 360f145 link true /test pull-kubernetes-e2e-ec2-conformance-canary
pull-kubernetes-e2e-ec2-canary 360f145 link true /test pull-kubernetes-e2e-ec2-canary

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants