Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP for PEAKS plugin #763

Merged
merged 3 commits into from
Sep 21, 2024
Merged

KEP for PEAKS plugin #763

merged 3 commits into from
Sep 21, 2024

Conversation

knarayan
Copy link
Contributor

@knarayan knarayan commented Jul 5, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Proposes a scheduler plugin for energy efficiency aware scheduling of pods on nodes (prioritize nodes with higher energy efficiency over nodes with lower energy efficiency for pod placement)

Which issue(s) this PR fixes:

Fixes # #800

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

NONE

Signed-off-by: Krishnasuri Narayanam <[email protected]>
@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 5, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @knarayan. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 5, 2024
Copy link

netlify bot commented Jul 5, 2024

Deploy Preview for kubernetes-sigs-scheduler-plugins ready!

Name Link
🔨 Latest commit 60d2301
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-scheduler-plugins/deploys/66ea8904fac0a70008ad6e66
😎 Deploy Preview https://deploy-preview-763--kubernetes-sigs-scheduler-plugins.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alculquicondor
Copy link

/assign @Huang-Wei

@ffromani
Copy link
Contributor

/cc

kep/tbd-peaks-power-aware-scheduling/README.md Outdated Show resolved Hide resolved
kep/tbd-peaks-power-aware-scheduling/README.md Outdated Show resolved Hide resolved
kep/tbd-peaks-power-aware-scheduling/README.md Outdated Show resolved Hide resolved
kep/tbd-peaks-power-aware-scheduling/README.md Outdated Show resolved Hide resolved
@ffromani
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 11, 2024
Copy link
Contributor

@Huang-Wei Huang-Wei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. @knarayan could you fix the CI failure by running hack/update-toc.sh?

Signed-off-by: Krishnasuri Narayanam <[email protected]>
@knarayan
Copy link
Contributor Author

LGTM overall. @knarayan could you fix the CI failure by running hack/update-toc.sh?

Thanks a lot, @Huang-Wei for reviewing the PEAKS KEP proposal. The CI failure is fixed after running hack/update-toc.sh as you have suggested.

@Huang-Wei
Copy link
Contributor

/label tide/merge-method-squash

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Sep 20, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Huang-Wei, knarayan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2024
@Huang-Wei
Copy link
Contributor

@knarayan could you fill in the release-notes section (in the PR description)? Then this PR will be auto-merged.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 21, 2024
@k8s-ci-robot k8s-ci-robot merged commit bb56af1 into kubernetes-sigs:master Sep 21, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants