feature: use contextal logging #813
Open
+211
−151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: googs1025 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-scheduler-plugins canceled.
|
k8s-ci-robot
added
the
size/M
googs1025
force-pushed
the
feature/contextual_logging
branch
2 times, most recently
from
111a6b2
to
1742b15
Compare
k8s-ci-robot
added
size/L
googs1025
force-pushed
the
feature/contextual_logging
branch
from
1742b15
to
737f913
Compare
|
/kind feature |
k8s-ci-robot
added
kind/feature
googs1025
force-pushed
the
feature/contextual_logging
branch
from
737f913
to
d933b58
Compare
googs1025
commented
Nov 2, 2024
| @@ -211,6 +213,8 @@ func (pgMgr *PodGroupManager) PreFilter(ctx context.Context, pod *corev1.Pod) er | |||
|
|
|||
| // Permit permits a pod to run, if the minMember match, it would send a signal to chan. | |||
| func (pgMgr *PodGroupManager) Permit(ctx context.Context, state *framework.CycleState, pod *corev1.Pod) Status { | |||
| lh := klog.FromContext(ctx) | |||
There was a problem hiding this comment.
klog.FromContext(ctx)
When using klog.FromContext(ctx), do I need to add WithValues to give it more information? 🤔
klog.FromContext(ctx).WithValues("PodGroupManager", "Unreserve")
googs1025
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Due to the large scope, I may only be able to complete part of the plugins work in this PR.
Which issue(s) this PR fixes:
Fixes # part of #743
Special notes for your reviewer:
Does this PR introduce a user-facing change?