Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-4788: Support mountPath replacing variable references with the values of given EnvVar #4820

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

KEP-4788: Support mountPath replacing variable references with the values of given EnvVar #4820

wants to merge 4 commits into from

Conversation

dongjiang1989
Copy link

  • One-line PR description: Support mountPath replacing variable references with the values of given EnvVar

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dongjiang1989
Once this PR has been reviewed and has the lgtm label, please assign derekwaynecarr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Sep 2, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Sep 2, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @dongjiang1989!

It looks like this is your first PR to kubernetes/enhancements 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/enhancements has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 2, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @dongjiang1989. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 2, 2024
@dongjiang1989
dongjiang, fix see-also
21c3d1f 
Signed-off-by: dongjiang1989 <[email protected]>
@dongjiang1989 dongjiang1989 mentioned this pull request Sep 2, 2024
Open
4 tasks
dongjiang1989
dongjiang1989 commented Sep 2, 2024
View reviewed changes
keps/sig-node/4788-volume-mountpath-env-expansion/README.md
args:
- --log_file=$(LOG_MOUNT_PATH)/myapp.log
volumeMounts:
- mountPath: $(LOG_MOUNT_PATH) #support mountPath env
Copy link
Author

@dongjiang1989 dongjiang1989 Sep 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change mountPath or add mountPathExpr?

@dongjiang1989 @iholder101
更新 README.md
995e579 
Co-authored-by: Itamar Holder <[email protected]>
@kannon92
Copy link
Contributor

kannon92 commented Sep 4, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 4, 2024
@dongjiang1989
make update-toc
67cb05b 
Signed-off-by: dongjiang1989 <[email protected]>
@dongjiang1989
Copy link
Author

/retest

@dongjiang1989
Copy link
Author

/sig sig-node

@k8s-ci-robot
Copy link
Contributor

@dongjiang1989: The label(s) sig/sig-node cannot be applied, because the repository doesn't have them.

In response to this:

/sig sig-node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dongjiang1989
Copy link
Author

/ok-to-test

Thanks. @kannon92 PTAL

pacoxu
pacoxu reviewed Sep 30, 2024
View reviewed changes
keps/sig-node/4788-volume-mountpath-env-expansion/README.md
metadata:
name: my-configMap
data:
LOG_MOUNT_PATH: "/opt/somepath"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Configmap can be updated, and what is the behavior when someone changed the configmap? Does this mean that kubelet should change the mountPath accordingly? It is weird to me.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, we shouldn't decouple environment variables from the pod itself, this seems dangerous and not a good design.

googs1025
googs1025 reviewed Sep 30, 2024
View reviewed changes
keps/sig-node/4788-volume-mountpath-env-expansion/README.md

#### Story 1

I used a configMap to store the mount path value, but when i call in my pod it doesn't work it seems that the mountPath property can not be assigned to an env variable.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can achieve something similar using an initContainer. The initContainer can write the required paths from specific ConfigMaps to a particular path within the pod, and the application container can directly read the required paths from that specific path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacoxu pacoxu pacoxu left review comments

@iholder101 iholder101 iholder101 left review comments

@googs1025 googs1025 googs1025 left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dongjiang1989 @k8s-ci-robot @kannon92 @pacoxu @iholder101 @googs1025