Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-753: SidecarContainers update oom score adj logic #4932

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

KEP-753: SidecarContainers update oom score adj logic #4932

wants to merge 1 commit into from

Conversation

bouaouda-achraf
Copy link

  • One-line PR description: update OOM score calculation.
  • Issue link: Sidecar Containers  #753
  • Other comments :
    The OOM adjustment for sidecar container will match or fall below the OOM score adjustment of regular containers in the Pod.

@bouaouda-achraf
update oom score adj logic
015890a 
The OOM adjustment for sidecar container will match or fall below the OOM score adjustment of regular containers in the Pod.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Oct 27, 2024
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 27, 2024
@bouaouda-achraf
Copy link
Author

linked with kubernetes/kubernetes#128029
adding @SergeyKanzhelev in the loop.

@bouaouda-achraf bouaouda-achraf mentioned this pull request Oct 27, 2024
Merged
SergeyKanzhelev
SergeyKanzhelev approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 28, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bouaouda-achraf, SergeyKanzhelev
Once this PR has been reviewed and has the lgtm label, please assign derekwaynecarr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SergeyKanzhelev
Copy link
Member

thank you for correcting. "The lower the better" values are always hard to reason correctly about

@kannon92
Copy link
Contributor

kannon92 commented Nov 1, 2024

/assign @mrunalp @dchen1107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@mrunalp mrunalp Awaiting requested review from mrunalp

Assignees

@mrunalp mrunalp

@dchen1107 dchen1107

@SergeyKanzhelev SergeyKanzhelev

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bouaouda-achraf @k8s-ci-robot @SergeyKanzhelev @kannon92 @mrunalp @dchen1107